fix: Add support for borderRadii on RectButton #2691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
requested changes
Dec 18, 2023
Co-authored-by: Jakub Piasecki <[email protected]>
j-piasecki
added a commit
that referenced
this pull request
Feb 5, 2024
This reverts commit 74c01a3.
j-piasecki
added a commit
that referenced
this pull request
Feb 5, 2024
## Description Reverts #2691. During testing before release, I've found some cases where the approach from PR doesn't work. At this point it may be better to leave the buttons as they are so we don't break any existing setups, and possibly reuse the logic for pressables.
|
Still reproduced in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screen.Recording.2023-12-12.at.11.34.21.mov
This PR adds support for border radius style props like:
borderTopLeftRadius,borderTopRightRadius,borderBottomLeftRadius,borderBottomRightRadiusto RectButton.It implements the border radii by wrapping a RawButton with two Views - the outer one curves the native RawButton and the inner acts like a mask cutting the corners of the button. The radius of the inner view had to be adjusted by subtracting the borderWidth from it - see this tweet.
FIxes #2594