Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Third of four stacked PRs for the shared C++ input core (#1127). Based on the web PR; review only the commits above it.
The iOS input now imports and exports markdown through the C++ core, so it produces the same markdown as web.
ENRMInputParser.mmandENRMMarkdownSerializer.mmare thin wrappers overMarkdown::Input::parseandserialize.cpp/inputis added toEnrichedMarkdownCore.podspecandReactNativeEnrichedMarkdown.podspec.ENRMInputRemend) is removed, so an unclosed*,_or[stays literal text.markdownLinePrefixForBlockRange:; the core writes the block markers.docs-md/BREAKING_CHANGES.mdlists what changes in stored markdown: escaping, link destinations, nested list indent, delimiter order, and unsupported syntax (quotes, code, tables) losing its markers on import.Testing
PR Checklist