Repository navigation
Conversation
jnowakow
force-pushed
the
feat/input-core-2-web
branch
from
November 13, 2026 11:27
b4a80fe to
0f8ddb1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Second of four stacked PRs for the shared C++ input core (#1127). Based on the core PR; review only the commits above it.
The web input now runs its import and export in the C++ core through wasm, and the TypeScript implementations are removed. The output is meant to stay the same as before.
_parseInputand_serializeInputare exported from the wasm module, andmd4c.jsis rebuilt (195,513 to 249,026 bytes).InputParser.tsandMarkdownSerializer.tskeep their exports and call the core throughinputCore.ts.onChangeMarkdownis held until it is ready and then emitted once.getMarkdown()and copy can't wait, so until the module is ready they return the plain text without markers and log one warning.markdownRoundTrip.test.tsreads the shared fixture files.markdownEscape.tsandnormalizeImport.ts.One known difference: a lone surrogate becomes one U+FFFD in the core, where the TypeScript wrote three.
Testing
PR Checklist