Repository navigation
fix: address the merge review of the streaming work - #1176
Merged
Merged
Conversation
hryhoriiK97
force-pushed
the
fix/merge-review
branch
from
November 12, 2026 23:14
21b610a to
e5b145c
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hryhoriiK97
force-pushed
the
fix/merge-review
branch
from
November 12, 2026 23:31
e5b145c to
852dcab
Compare
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from five Fable reviews of #1140 (core C++, iOS, Android, JS/TS API, docs). The reviews found no blockers. This PR fixes the correctness, docs and comment findings; the deferred items are listed in the follow-ups doc.
Fixes
TextViewLayoutManageris set onto layout managers UIKit already made (object_setClass), so an ivar's storage lies past the instance. The glyph colour that fade and gradient draw with was such an ivar; it is now an associated object, like the class's other state. A test checks the class has no ivars.mayDefineLinkReferenceaccepted a closing fence at any indent but opened fences only at column 0. An indented opener, or an over-indented closer inside a fence, flipped its state, so a later[ref]: urlwas skipped and[ref]stayed plain text until the stream ended. A closer now counts at 0–3 spaces of indent. A fence line the scan can't follow switches fence tracking off: one that's indented, inside a quote or list, or right after a line with|. New fixtures inincremental_parse_testcover these cases and a tab-indented closer.streamingnow measures in full, so it has its height on the first commit. Tested on both platforms.EnrichedMarkdownTextparks its renders, so it now clears its laid-out size on detach and when it parks one.StreamMeasurementTesthas the sequence.EnrichedMarkdownDisableTextTilestoYESinInfo.plistdraws text the standard way, in case a future iOS changes the private views the tiles rely on. Documented in known limitations, with the off-screen snapshot limit.react-native. (Platform files would not work here: web code imports its.webfiles by name, and the docs site's bundler doesn't resolve platform extensions.)Docs
streamingAnimationentry. It notes thatstreamingConfignow applies underflavor="commonmark"too, and gives a migrate step.react-native-streamdown" section and checklist.react-native-streamdownis described as no longer needed rather than deprecated.mediaModeadded toAPI_REFERENCE.md. AnonStreamingEndexample in the guide, and a note that it doesn't fire on web.'progressive'code block header is qualified as github-only, overstated claims are softened, a repeated sentence is removed, and thestreamplatform reads Both, Web.Comments and cleanup
BlockKinds.hpp, the two HTML-list comments,MeasureConfig, and thefinishedBytescontract (it can go back after a quoted fence).document_store_test's concurrency check was flaky under the thread sanitizer. A lagging thread could store an older state after the newest, and the byte budget could then drop the newest. It now checks the shared tree on one last state that all three threads parse at once.destinationEnd's unusedstopparameter and Android'sscheduleRenderIfNeededalias.stream, and notes the macOS animation fallback.Testing
onStreamingEndfires once in each;🤖 Generated with Claude Code