Repository navigation
fix: streaming end event, iOS effects frame rate and two Android guards - #1167
Merged
Merged
Conversation
Every host called onStreamingEnd as streaming stopped, then rendered the whole text: a handler that scrolled to the end or measured saw the height before the final render. The event now waits for the first render scheduled after the stream ended, unless that render asks for another in full (a view that missed a patch), and fires at once when there is nothing to render or a new stream starts first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t off a window The display link that redraws fading text had no frame rate range, so it ran at 120 Hz on ProMotion screens while the core's pacer runs at 30, and it kept ticking for a text view that left its window while text arrived. It now asks for 30 to 60 Hz, stops off a window, and starts again when the text view is back on one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…irection A stream update took the view's laid-out size when a 32-bit hash of the layout props matched the last measurement's, and the hash left out the screen density and the layout direction. A collision or a density or direction change could hand back a size laid out for other props. The key is now a data class compared whole, as iOS compares its key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resuming a text segment at a top-level node trusted that the node before it ends in "\n"; a node kind that didn't would join the next one's first line. The cache now records where the text before each node ends in a newline and renders in full elsewhere. iOS guards its resume too, by comparing the text before it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
The second follow-up to #1140: three streaming fixes found in the stack's final review. It targets #1140's branch, so it lands with it.
Changes
onStreamingEndfires once the last words are on screen (all four hosts).Testing
onStreamingEnd.onStreamingEndonce and ends at the height of a static mount;onStreamingEndonce and ends at the static height.PR Checklist
🤖 Generated with Claude Code