fix(android): a long-press drag selection is no longer stolen by a scrolling parent

packages/enriched-markdown-android/ui/src/main/java/com/swmansion/enriched/markdown/utils/text/view/LinkLongPressMovementMethod.kt

@@ -30,8 +30,7 @@ class LinkLongPressMovementMethod : ArrowKeyMovementMethod() {
   private var pressedLink: LinkSpan? = null
   private var pressedSpoiler: SpoilerSpan? = null
 
-  var isLinkTouchActive: Boolean = false
-    private set
+  private var isLinkTouchActive: Boolean = false
   private var isTouchWithinTextBounds: Boolean = true
 
   override fun onTouchEvent(

packages/react-native-enriched-markdown/android/src/main/java/com/swmansion/enriched/markdown/EnrichedMarkdownInternalText.kt

@@ -19,7 +19,6 @@ import com.swmansion.enriched.markdown.utils.text.view.applySelectableState
 import com.swmansion.enriched.markdown.utils.text.view.cancelJSTouchForCheckboxTap
 import com.swmansion.enriched.markdown.utils.text.view.cancelJSTouchForLinkTap
 import com.swmansion.enriched.markdown.utils.text.view.createSelectionActionModeCallback
-import com.swmansion.enriched.markdown.utils.text.view.reallowParentInterceptIfLinkReleased
 import com.swmansion.enriched.markdown.utils.text.view.setupAsMarkdownTextView
 
 class EnrichedMarkdownInternalText
@@ -116,10 +115,7 @@ class EnrichedMarkdownInternalText
         return true
       }
       val result = super.onTouchEvent(event)
-      when (event.action) {
-        MotionEvent.ACTION_DOWN -> cancelJSTouchForLinkTap(event)
-        else -> reallowParentInterceptIfLinkReleased()
-      }
+      if (event.action == MotionEvent.ACTION_DOWN) cancelJSTouchForLinkTap(event)
       return result
     }
 

packages/react-native-enriched-markdown/android/src/main/java/com/swmansion/enriched/markdown/EnrichedMarkdownText.kt

@@ -47,7 +47,6 @@ import com.swmansion.enriched.markdown.utils.text.view.createSelectionActionMode
 import com.swmansion.enriched.markdown.utils.text.view.emitImagePressEvent
 import com.swmansion.enriched.markdown.utils.text.view.emitLinkLongPressEvent
 import com.swmansion.enriched.markdown.utils.text.view.emitLinkPressEvent
-import com.swmansion.enriched.markdown.utils.text.view.reallowParentInterceptIfLinkReleased
 import com.swmansion.enriched.markdown.utils.text.view.setupAsMarkdownTextView
 import java.util.concurrent.Executors
 import kotlin.math.ceil
@@ -620,10 +619,7 @@ class EnrichedMarkdownText
         return true
       }
       val result = super.onTouchEvent(event)
-      when (event.action) {
-        MotionEvent.ACTION_DOWN -> cancelJSTouchForLinkTap(event)
-        else -> reallowParentInterceptIfLinkReleased()
-      }
+      if (event.action == MotionEvent.ACTION_DOWN) cancelJSTouchForLinkTap(event)
       return result
     }
 

packages/react-native-enriched-markdown/android/src/main/java/com/swmansion/enriched/markdown/segments/TableContainerView.kt

@@ -37,7 +37,6 @@ import com.swmansion.enriched.markdown.utils.text.extensions.replaceMathSpansWit
 import com.swmansion.enriched.markdown.utils.text.span.prepareWidthAwareSpans
 import com.swmansion.enriched.markdown.utils.text.view.LinkLongPressMovementMethod
 import com.swmansion.enriched.markdown.utils.text.view.cancelJSTouchForLinkTap
-import com.swmansion.enriched.markdown.utils.text.view.reallowParentInterceptIfLinkReleased
 import com.swmansion.enriched.markdown.views.ContextMenuPopup
 import kotlin.math.ceil
 import kotlin.math.max
@@ -621,10 +620,7 @@ class TableContainerView(
 
     override fun onTouchEvent(event: MotionEvent): Boolean {
       val result = super.onTouchEvent(event)
-      when (event.action) {
-        MotionEvent.ACTION_DOWN -> cancelJSTouchForLinkTap(event)
-        else -> reallowParentInterceptIfLinkReleased()
-      }
+      if (event.action == MotionEvent.ACTION_DOWN) cancelJSTouchForLinkTap(event)
       return result
     }
   }

packages/react-native-enriched-markdown/android/src/main/java/com/swmansion/enriched/markdown/utils/text/view/LinkEvents.kt

@@ -38,34 +38,16 @@ fun View.emitLinkLongPressEvent(url: String) {
  * Cancels the JS touch for an active link tap, preventing parent
  * Pressable/TouchableOpacity from firing onPress for the same tap.
  *
- * Also requests that parent ViewGroups do not intercept subsequent touch
- * events in this gesture. This is necessary for react-native-gesture-handler's
- * Pressable, which intercepts at the native ViewGroup level and would otherwise
- * steal the gesture before ACTION_UP reaches the TextView.
+ * Parent intercept is handled by [LinkLongPressMovementMethod], which
+ * disallows it for the press and releases it when the press ends.
  */
 fun TextView.cancelJSTouchForLinkTap(event: MotionEvent) {
   val currentMovementMethod = movementMethod
   if (currentMovementMethod is LinkLongPressMovementMethod && currentMovementMethod.isLinkTouchActive) {
-    parent?.requestDisallowInterceptTouchEvent(true)
     NativeGestureUtil.notifyNativeGestureStarted(this, event)
   }
 }
 
-/**
- * Re-allows parent ViewGroups to intercept touch events once the link
- * touch is no longer active (slop exceeded, gesture ended, or cancelled).
- * This restores normal scrolling behavior for parent ScrollView/RecyclerView.
- *
- * Must be called after [LinkLongPressMovementMethod.onTouchEvent] has
- * processed the event, since that is where [isLinkTouchActive] is updated.
- */
-fun TextView.reallowParentInterceptIfLinkReleased() {
-  val currentMovementMethod = movementMethod
-  if (currentMovementMethod is LinkLongPressMovementMethod && !currentMovementMethod.isLinkTouchActive) {
-    parent?.requestDisallowInterceptTouchEvent(false)
-  }
-}
-
 /**
  * Cancels the JS touch unconditionally, preventing parent
  * Pressable/TouchableOpacity from firing onPress for the same gesture.

packages/react-native-enriched-markdown/android/src/main/java/com/swmansion/enriched/markdown/utils/text/view/LinkLongPressMovementMethod.kt

@@ -38,6 +38,7 @@ class LinkLongPressMovementMethod : ArrowKeyMovementMethod() {
   var isLinkTouchActive: Boolean = false
     private set
   private var isTouchWithinTextBounds: Boolean = true
+  private var disallowsParentIntercept = false
 
   override fun onTouchEvent(
     widget: TextView,
@@ -71,6 +72,9 @@ class LinkLongPressMovementMethod : ArrowKeyMovementMethod() {
         isLinkTouchActive = pressedLink != null || pressedImage != null || pressedCodeBlock != null
         isTouchWithinTextBounds = charOffsetAt(widget, event) != null || pressedCodeBlock != null
         pressedLink?.let { scheduleLongPress(widget, it) }
+        // Keeps RNGH Pressable and scrolling parents from stealing the press before ACTION_UP.
+        disallowsParentIntercept = isLinkTouchActive
+        if (isLinkTouchActive) widget.parent?.requestDisallowInterceptTouchEvent(true)
       }
 
       MotionEvent.ACTION_MOVE -> {
@@ -83,6 +87,7 @@ class LinkLongPressMovementMethod : ArrowKeyMovementMethod() {
           pressedLink = null
           pressedImage = null
           pressedCodeBlock = null
+          releaseParentIntercept(widget)
         }
       }
 
@@ -95,6 +100,7 @@ class LinkLongPressMovementMethod : ArrowKeyMovementMethod() {
         pressedLink = null
         pressedImage = null
         pressedCodeBlock = null
+        releaseParentIntercept(widget)
 
         if (handleSpoilerTap(widget, buffer, event)) {
           return true
@@ -125,6 +131,7 @@ class LinkLongPressMovementMethod : ArrowKeyMovementMethod() {
         pressedLink = null
         pressedImage = null
         pressedCodeBlock = null
+        releaseParentIntercept(widget)
       }
     }
 
@@ -163,6 +170,14 @@ class LinkLongPressMovementMethod : ArrowKeyMovementMethod() {
     longPressRunnable = null
   }
 
+  // Undo only our own request: a long-press drag selection relies on the Editor's
+  // request staying in place until ACTION_UP, or a scrolling parent steals the drag.
+  private fun releaseParentIntercept(widget: TextView) {
+    if (!disallowsParentIntercept) return
+    disallowsParentIntercept = false
+    widget.parent?.requestDisallowInterceptTouchEvent(false)
+  }
+
   private fun charOffsetAt(
     widget: TextView,
     event: MotionEvent,