-
-
Notifications
You must be signed in to change notification settings - Fork 28
feat: Ref/Value behavior tracking #1755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iwoplaza
wants to merge
64
commits into
main
Choose a base branch
from
feat/ref-value
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
reference to something define in that function)
the value proxies
|
Something weird happened to the vaporrave example, some of the effects seem to have disappeared. Also, Slime Mold 3D throws when switching to another example, but this might have been the case before. |
assigning primitives to const variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
conststatements be pointers if they take in a referential type (let statements)conststatements with naturally non-referential types to be WGSLconst🎉TODO:
const some = layout.$.data) local to functions, and not leak into shell-less functions signatures. This ensures that a function doesn't accidentally have access to a value it shouldn't have access to.Reference assignment errors:
Invalid 'let' statement errors:
