Skip to content

Conversation

@stephenway
Copy link
Contributor

@stephenway stephenway commented Oct 6, 2025

  • Add working_directory input to resolve file globs relative to a specified base directory instead of always using repo root.
  • Updated glob resolution functions to accept and use the working directory parameter for both file matching and unmatched pattern detection.
  • Add tests to verify the new behavior works correctly while maintaining backward compatibility.

closes #458
closes #158

@stephenway stephenway changed the title feat: respect working_directory for files globs; add input and tests feat(action): respect working_directory for files globs; add input and tests Oct 6, 2025
@stephenway stephenway changed the title feat(action): respect working_directory for files globs; add input and tests feat(action): respect working_directory for files globs Oct 6, 2025
@chenrui333
Copy link
Collaborator

Thanks @stephenway!

@chenrui333 chenrui333 merged commit 4db716b into softprops:master Oct 7, 2025
1 check passed
@chenrui333
Copy link
Collaborator

released in 2.4.0

mergify bot added a commit to robfrank/linklift that referenced this pull request Oct 15, 2025
Bumps the github-actions group with 2 updates: [softprops/action-gh-release](https://github.com/softprops/action-gh-release) and [ruby/setup-ruby](https://github.com/ruby/setup-ruby).
Updates `softprops/action-gh-release` from 2.3.4 to 2.4.1
Release notes

*Sourced from [softprops/action-gh-release's releases](https://github.com/softprops/action-gh-release/releases).*

> v2.4.1
> ------
>
> What's Changed
> --------------
>
> ### Other Changes 🔄
>
> * fix(util): support brace expansion globs containing commas in parseInputFiles by [`@​Copilot`](https://github.com/Copilot) in [softprops/action-gh-release#672](https://redirect.github.com/softprops/action-gh-release/pull/672)
> * fix: gracefully fallback to body when body\_path cannot be read by [`@​Copilot`](https://github.com/Copilot) in [softprops/action-gh-release#671](https://redirect.github.com/softprops/action-gh-release/pull/671)
>
> **Full Changelog**: <softprops/action-gh-release@v2...v2.4.1>
>
> v2.4.0
> ------
>
> What's Changed
> --------------
>
> ### Exciting New Features 🎉
>
> * feat(action): respect working\_directory for files globs by [`@​stephenway`](https://github.com/stephenway) in [softprops/action-gh-release#667](https://redirect.github.com/softprops/action-gh-release/pull/667)
>
> ### Other Changes 🔄
>
> * chore(deps): bump the npm group with 2 updates by [`@​dependabot`](https://github.com/dependabot)[bot] in [softprops/action-gh-release#668](https://redirect.github.com/softprops/action-gh-release/pull/668)
>
> **Full Changelog**: <softprops/action-gh-release@v2.3.4...v2.4.0>


Changelog

*Sourced from [softprops/action-gh-release's changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md).*

> 2.4.1
> -----
>
> What's Changed
> --------------
>
> ### Other Changes 🔄
>
> * fix(util): support brace expansion globs containing commas in parseInputFiles by [`@​Copilot`](https://github.com/Copilot) in [softprops/action-gh-release#672](https://redirect.github.com/softprops/action-gh-release/pull/672)
> * fix: gracefully fallback to body when body\_path cannot be read by [`@​Copilot`](https://github.com/Copilot) in [softprops/action-gh-release#671](https://redirect.github.com/softprops/action-gh-release/pull/671)
>
> 2.4.0
> -----
>
> What's Changed
> --------------
>
> ### Exciting New Features 🎉
>
> * feat(action): respect working\_directory for files globs by [`@​stephenway`](https://github.com/stephenway) in [softprops/action-gh-release#667](https://redirect.github.com/softprops/action-gh-release/pull/667)
>
> 2.3.4
> -----
>
> What's Changed
> --------------
>
> ### Bug fixes 🐛
>
> * fix(action): handle 422 already\_exists race condition by [`@​stephenway`](https://github.com/stephenway) in [softprops/action-gh-release#665](https://redirect.github.com/softprops/action-gh-release/pull/665)
>
> ### Other Changes 🔄
>
> * dependency updates
>
> 2.3.3
> -----
>
> What's Changed
> --------------
>
> ### Exciting New Features 🎉
>
> * feat: add input option `overwrite_files` by [`@​asfernandes`](https://github.com/asfernandes) in [softprops/action-gh-release#343](https://redirect.github.com/softprops/action-gh-release/pull/343)
>
> ### Other Changes 🔄
>
> * dependency updates
>
> 2.3.2
> -----
>
> * fix: revert fs `readableWebStream` change
>
> 2.3.1
> -----
>
> ### Bug fixes 🐛
>
> * fix: fix file closing issue by [`@​WailGree`](https://github.com/WailGree) in [softprops/action-gh-release#629](https://redirect.github.com/softprops/action-gh-release/pull/629)

... (truncated)


Commits

* [`6da8fa9`](softprops/action-gh-release@6da8fa9) release 2.4.1
* [`f38efde`](softprops/action-gh-release@f38efde) fix: gracefully fallback to body when body\_path cannot be read ([#671](https://redirect.github.com/softprops/action-gh-release/issues/671))
* [`cec1a11`](softprops/action-gh-release@cec1a11) fix(util): support brace expansion globs containing commas in parseInputFiles...
* [`aec2ec5`](softprops/action-gh-release@aec2ec5) release 2.4.0
* [`4db716b`](softprops/action-gh-release@4db716b) feat: respect working\_directory for files globs; add input and tests ([#667](https://redirect.github.com/softprops/action-gh-release/issues/667))
* [`14820f2`](softprops/action-gh-release@14820f2) chore(deps): bump the npm group with 2 updates ([#668](https://redirect.github.com/softprops/action-gh-release/issues/668))
* See full diff in [compare view](softprops/action-gh-release@62c96d0...6da8fa9)
  
Updates `ruby/setup-ruby` from 1.263.0 to 1.265.0
Release notes

*Sourced from [ruby/setup-ruby's releases](https://github.com/ruby/setup-ruby/releases).*

> v1.265.0
> --------
>
> What's Changed
> --------------
>
> * Update CRuby releases on Windows by [`@​ruby-builder-bot`](https://github.com/ruby-builder-bot) in [ruby/setup-ruby#817](https://redirect.github.com/ruby/setup-ruby/pull/817)
>
> **Full Changelog**: <ruby/setup-ruby@v1.264.0...v1.265.0>
>
> v1.264.0
> --------
>
> What's Changed
> --------------
>
> * Add ruby-3.4.7 by [`@​ruby-builder-bot`](https://github.com/ruby-builder-bot) in [ruby/setup-ruby#815](https://redirect.github.com/ruby/setup-ruby/pull/815)
>
> **Full Changelog**: <ruby/setup-ruby@v1.263.0...v1.264.0>


Commits

* [`ab177d4`](ruby/setup-ruby@ab177d4) Update CRuby releases on Windows
* [`6797dcb`](ruby/setup-ruby@6797dcb) Add ruby-3.4.7
* [`a16e0e6`](ruby/setup-ruby@a16e0e6) Test on macos-15-intel too
* See full diff in [compare view](ruby/setup-ruby@0481980...ab177d4)
  
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore  major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore  minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore  ` will remove the ignore condition of the specified dependency and ignore conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

files option does not respect working-directory setting With.files input doesn't work correctly when working-directory is set

2 participants