Compatiblilty with larger drills#11
Merged
softmix merged 3 commits intosoftmix:masterfrom Nov 20, 2021
nicolas-lang:master
Merged
Compatiblilty with larger drills#11softmix merged 3 commits intosoftmix:masterfrom nicolas-lang:master
softmix merged 3 commits intosoftmix:masterfrom
nicolas-lang:master
Conversation
added 2 commits
August 1, 2021 10:52
Collaborator
|
This PR also addresses #14. Just one comment, in your addition to |
Collaborator
Author
|
there is no |
Collaborator
|
Oh yes, my bad. I'll test this tomorrow! Would be great for it to work with the miners in my Space Exploration game. |
Collaborator
|
I have tested that the surface checking code works, both when upgrading the mod and when adding it to an existing save. The fluid box code also works with 3x3 miners. Haven't tested it with larger ones yet. |
Owner
|
Thank you for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the report at the mods portal, I have modified the pipe building to be based on the fluid box prototype instead being hardcoded.
I have done a couple of tests with the bigger AAI drills and it seems to be working fine. Unfortunately nobody in the mod portal forums offered test-feedback.
While I like the general structure of the new logic there are two places where I am unsure:
1.
local fluidbox_prototype = drill.fluidbox.get_prototype(1)is this the way to get the correct fluid box, or would usinggame.entity_prototypes[drill.name](and then go to the members) be more correct...2.
autodeconstruct.build_pipe(drillData, pipeType, conn.positions[1])... why has the fluidbox prototype an array for each connection even though the drill was only created with a single location for the connection. This seems strange but works...
I'll just open it as a pull request for now, maybe you can also have a look.
A pre-realease test package (zip) is available at https://github.com/nicolas-lang/AutoDeconstruct/releases
P.S. ( I was busy and the invite timed out)