Skip to content

Conversation

@ratmice
Copy link
Collaborator

@ratmice ratmice commented Mar 17, 2025

Note this adds missing licenses to the allow list, to make the cargo deny check succeed.
Without regard to whether we actually want to allow those licenses
I've never actually read or heard of the Unicode-3.0 license.

In trying to figure out a testing strategy for wasm and the PR in #527
Previously in other things I had been running .buildbot.sh on a failing branch, when adding that cache check.
Running it here on a working branch I noticed the cargo-deny check license script was failing,
for a few reasons.

So now I'm wondering if the .buildbot.sh and the ci script are somehow out-of-sync,
This would seem to explain why I could never get #513 to fail.

@ratmice
Copy link
Collaborator Author

ratmice commented Mar 17, 2025

Setting as draft until people have chimed in at least on the additional licenses.

Speaking for myself (of course!), Unicode-3.0 appears to just be MIT but also covering data files, so I have no qualms with the changes.

@ltratt
Copy link
Member

ltratt commented Mar 17, 2025

These are all good: we've used this exact set of licenses elsewhere. Please squash.

@ratmice ratmice marked this pull request as ready for review March 17, 2025 14:47
@ratmice
Copy link
Collaborator Author

ratmice commented Mar 17, 2025

Squashed.

@ltratt ltratt added this pull request to the merge queue Mar 17, 2025
Merged via the queue into softdevteam:master with commit 9e92910 Mar 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants