Skip to content

Conversation

@HzjNeverStop
Copy link
Contributor

No description provided.

@HzjNeverStop HzjNeverStop changed the title Dependency loop detection Module self depend on detection Jun 22, 2022
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #990 (e100ddf) into master (29bbf0e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #990      +/-   ##
============================================
- Coverage     11.47%   11.47%   -0.01%     
  Complexity       39       39              
============================================
  Files           311      311              
  Lines          9086     9090       +4     
  Branches       1252     1254       +2     
============================================
  Hits           1043     1043              
- Misses         7891     7895       +4     
  Partials        152      152              
Impacted Files Coverage Δ
...om/alipay/sofa/isle/deployment/DependencyTree.java 2.89% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29bbf0e...e100ddf. Read the comment docs.

@alaneuler
Copy link
Contributor

这个是不是可以做的通用点呢,依赖链存在环。

@HzjNeverStop
Copy link
Contributor Author

这个是不是可以做的通用点呢,依赖链存在环。

现有的逻辑已经支持检测出环了,故不再重复检测

Copy link
Contributor

@alaneuler alaneuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HzjNeverStop HzjNeverStop merged commit b8ba1d7 into sofastack:master Jul 5, 2022
@HzjNeverStop HzjNeverStop deleted the dependency_loop_detection branch February 22, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants