-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Module self depend on detection #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module self depend on detection #990
Conversation
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
============================================
- Coverage 11.47% 11.47% -0.01%
Complexity 39 39
============================================
Files 311 311
Lines 9086 9090 +4
Branches 1252 1254 +2
============================================
Hits 1043 1043
- Misses 7891 7895 +4
Partials 152 152
Continue to review full report at Codecov.
|
|
这个是不是可以做的通用点呢,依赖链存在环。 |
现有的逻辑已经支持检测出环了,故不再重复检测 |
alaneuler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.