Skip to content

Update ProxyBeanFactoryPostProcessor invoke order #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HzjNeverStop merged 4 commits into from
May 27, 2022
Merged

Update ProxyBeanFactoryPostProcessor invoke order #971

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e5621e
support single SofaProxyFactoryBean
May 27, 2022
3dd771c
Revert "support single SofaProxyFactoryBean"
May 27, 2022
55d2745
优化 ProxyBeanFactoryPostProcessor
May 27, 2022
06482ee
update order
May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 26 additions & 13 deletions ...-sofa-boot/src/main/java/com/alipay/sofa/runtime/proxy/ProxyBeanFactoryPostProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,25 +20,29 @@
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.BeanFactoryUtils;
import org.springframework.beans.factory.config.BeanDefinition;
import org.springframework.beans.factory.config.BeanFactoryPostProcessor;
import org.springframework.beans.factory.config.ConfigurableListableBeanFactory;
import org.springframework.beans.factory.support.BeanDefinitionRegistry;
import org.springframework.beans.factory.support.BeanDefinitionRegistryPostProcessor;
import org.springframework.core.PriorityOrdered;

/**
*
* 更新 ProxyFactoryBean 以避免被提前初始化
* <p> 这里必须实现 BeanDefinitionRegistryPostProcessor 接口且声明最高优先级的 Ordered，
* 否则如果其他 BeanDefinitionRegistryPostProcessor 使用了构造函数注入则会导致 ProxyFactoryBean 被提前初始化
* @author ruoshan
* @since 3.12.0
*/
public class ProxyBeanFactoryPostProcessor implements BeanFactoryPostProcessor, PriorityOrdered {
public class ProxyBeanFactoryPostProcessor implements BeanDefinitionRegistryPostProcessor,
PriorityOrdered {

@Override
public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory)
throws BeansException {
public void postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry)
throws BeansException {
boolean updateProxyBean = false;
for (String beanName : beanFactory.getBeanNamesForType(ProxyFactoryBean.class, true, false)) {
for (String beanName : registry.getBeanDefinitionNames()) {
String transformedBeanName = BeanFactoryUtils.transformedBeanName(beanName);
if (beanFactory.containsBeanDefinition(transformedBeanName)) {
BeanDefinition beanDefinition = beanFactory.getBeanDefinition(transformedBeanName);
if (registry.containsBeanDefinition(transformedBeanName)) {
BeanDefinition beanDefinition = registry.getBeanDefinition(transformedBeanName);
if (ProxyFactoryBean.class.getName().equals(beanDefinition.getBeanClassName())) {
beanDefinition.setBeanClassName(SofaProxyFactoryBean.class.getName());
Object proxyInterfaces = beanDefinition.getPropertyValues().get(
Expand All @@ -52,20 +56,29 @@ public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory)
beanDefinition.getPropertyValues().get("targetName"));
beanDefinition.getConstructorArgumentValues().addIndexedArgumentValue(2,
beanDefinition.getPropertyValues().get("targetClass"));
beanDefinition.getConstructorArgumentValues().addIndexedArgumentValue(3,
beanFactory);
// must be true
if (registry instanceof ConfigurableListableBeanFactory) {
beanDefinition.getConstructorArgumentValues().addIndexedArgumentValue(3,
registry);
}
updateProxyBean = true;
}
}
}
if (updateProxyBean) {
if (updateProxyBean && registry instanceof ConfigurableListableBeanFactory) {
// must clear metadata cache
beanFactory.clearMetadataCache();
((ConfigurableListableBeanFactory) registry).clearMetadataCache();
}
}

@Override
public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory)
throws BeansException {

}

@Override
public int getOrder() {
return 0;
return PriorityOrdered.HIGHEST_PRECEDENCE;
}
}