Skip to content

clean sofa-boot-samples module #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alaneuler merged 1 commit into from
Oct 27, 2020
Merged

clean sofa-boot-samples module #745

alaneuler merged 1 commit into from
Oct 27, 2020

Conversation

@HzjNeverStop
Copy link
Contributor

@HzjNeverStop HzjNeverStop commented Oct 27, 2020

fix #744

@HzjNeverStop HzjNeverStop added this to the 3.4.6 milestone Oct 27, 2020
alaneuler
alaneuler approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@alaneuler alaneuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alaneuler alaneuler merged commit 7b55211 into sofastack:master Oct 27, 2020
@HzjNeverStop HzjNeverStop deleted the remoce_sample_module branch November 6, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alaneuler alaneuler alaneuler approved these changes

Assignees

No one assigned

Labels

cla:yes size/S

Projects

None yet

Milestone

3.4.6

Development

Successfully merging this pull request may close these issues.

clean sofa-boot-samples module

2 participants

@HzjNeverStop @alaneuler