Register module ApplicationContext as sofa components #740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| application.setAppName(appName); | ||
|
|
||
| Map<String, SofaRuntimeManager> sofaRuntimeManagers = applicationContext | ||
| .getBeansOfType(SofaRuntimeManager.class); |
Contributor
There was a problem hiding this comment.
为何不使用org.springframework.beans.factory.BeanFactory#getBean(java.lang.Class), 该方法抛出的异常包含了各类场景
Contributor
Author
There was a problem hiding this comment.
这一块主要是新增的逻辑。。。不知道有什么异常情况，尽量不影响之前的启动逻辑
Contributor
There was a problem hiding this comment.
在这个类中SofaRuntimeManager获取有问题肯定是有异常原因导致的，应该直接抛出spring的异常阻止应用启动，而不是打印error日志
...-core/isle-sofa-boot/src/main/java/com/alipay/sofa/isle/stage/SpringContextInstallStage.java
Outdated
Show resolved
Hide resolved
| * | ||
| * @author khotyn Created on 2020/10/26 | ||
| */ | ||
| public class SpringComponent extends AbstractComponent { |
Contributor
There was a problem hiding this comment.
叫SpringContextComponent是否好一点，不然以为是spring bean的component
added 2 commits
October 27, 2020 17:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #667