Skip to content

Conversation

@HzjNeverStop
Copy link
Contributor

No description provided.

致节 added 3 commits August 10, 2020 11:40
# Conflicts:
#	pom.xml
#	sofa-boot-project/pom.xml
#	sofa-boot-project/sofa-boot-actuator-autoconfigure/pom.xml
#	sofa-boot-project/sofa-boot-actuator/pom.xml
#	sofa-boot-project/sofa-boot-autoconfigure/pom.xml
#	sofa-boot-project/sofa-boot-core/healthcheck-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/isle-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/log-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/pom.xml
#	sofa-boot-project/sofa-boot-core/rpc-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/runtime-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/startup-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/test-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/tracer-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-parent/pom.xml
#	sofa-boot-project/sofa-boot-plugins/pom.xml
#	sofa-boot-project/sofa-boot-plugins/rpc-sofa-boot-plugin/pom.xml
#	sofa-boot-project/sofa-boot-plugins/runtime-sofa-boot-plugin/pom.xml
#	sofa-boot-project/sofa-boot-plugins/tracer-sofa-boot-plugin/pom.xml
#	sofa-boot-project/sofa-boot-starters/healthcheck-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/infra-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/isle-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/log-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/pom.xml
#	sofa-boot-project/sofa-boot-starters/rpc-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/runtime-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/startup-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/test-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/tracer-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-tools/pom.xml
#	sofa-boot-project/sofa-boot-tools/sofa-boot-gradle-plugin/build.gradle
#	sofa-boot-project/sofa-boot-tools/sofa-boot-gradle-plugin/pom.xml
#	sofa-boot-project/sofa-boot/pom.xml
#	sofa-boot-project/sofaboot-dependencies/pom.xml
@sofastack-bot sofastack-bot bot added bug Something isn't working cla:yes size/M labels Aug 28, 2020
@HzjNeverStop HzjNeverStop linked an issue Aug 28, 2020 that may be closed by this pull request
@HzjNeverStop HzjNeverStop changed the title Fix extension healthcheck bug Closes #694 Fix extension healthcheck bug Aug 28, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #697 into master will decrease coverage by 0.10%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #697      +/-   ##
============================================
- Coverage     51.74%   51.63%   -0.11%     
  Complexity       78       78              
============================================
  Files           291      291              
  Lines          8187     8198      +11     
  Branches       1142     1143       +1     
============================================
- Hits           4236     4233       -3     
- Misses         3500     3506       +6     
- Partials        451      459       +8     
Impacted Files Coverage Δ Complexity Δ
...sofa/runtime/ext/component/ExtensionComponent.java 57.40% <0.00%> (-4.14%) 0.00 <0.00> (ø)
...com/alipay/sofa/runtime/SofaRuntimeProperties.java 69.23% <66.66%> (-0.77%) 0.00 <0.00> (ø)
.../configure/SofaRuntimeConfigurationProperties.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ime/component/impl/StandardSofaRuntimeManager.java 71.69% <0.00%> (-5.67%) 0.00% <0.00%> (ø%)
...m/alipay/sofa/isle/stage/ModuleLogOutputStage.java 84.76% <0.00%> (-3.81%) 0.00% <0.00%> (ø%)
.../sofa/runtime/spi/component/AbstractComponent.java 43.28% <0.00%> (-2.99%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cbdc2d...06828b7. Read the comment docs.

Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glmapper glmapper merged commit d50d777 into sofastack:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla:yes size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HealthCheck passed when ExtensionComponent activate failed

3 participants