Skip to content

Conversation

@HzjNeverStop
Copy link
Contributor

fix #672

@HzjNeverStop HzjNeverStop added the enhancement New feature or request label Jul 20, 2020
@HzjNeverStop HzjNeverStop added this to the v3.4.2 milestone Jul 20, 2020
@alaneuler alaneuler modified the milestones: v3.4.2, v3.4.3 Jul 22, 2020
致节 and others added 3 commits July 31, 2020 10:13
# Conflicts:
#	pom.xml
#	sofa-boot-project/pom.xml
#	sofa-boot-project/sofa-boot-actuator-autoconfigure/pom.xml
#	sofa-boot-project/sofa-boot-actuator/pom.xml
#	sofa-boot-project/sofa-boot-autoconfigure/pom.xml
#	sofa-boot-project/sofa-boot-core/healthcheck-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/isle-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/log-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/pom.xml
#	sofa-boot-project/sofa-boot-core/rpc-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/runtime-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/test-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-core/tracer-sofa-boot/pom.xml
#	sofa-boot-project/sofa-boot-parent/pom.xml
#	sofa-boot-project/sofa-boot-plugins/pom.xml
#	sofa-boot-project/sofa-boot-plugins/rpc-sofa-boot-plugin/pom.xml
#	sofa-boot-project/sofa-boot-plugins/runtime-sofa-boot-plugin/pom.xml
#	sofa-boot-project/sofa-boot-plugins/tracer-sofa-boot-plugin/pom.xml
#	sofa-boot-project/sofa-boot-starters/healthcheck-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/infra-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/isle-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/log-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/pom.xml
#	sofa-boot-project/sofa-boot-starters/rpc-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/runtime-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/test-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-starters/tracer-sofa-boot-starter/pom.xml
#	sofa-boot-project/sofa-boot-tools/pom.xml
#	sofa-boot-project/sofa-boot-tools/sofa-boot-gradle-plugin/build.gradle
#	sofa-boot-project/sofa-boot-tools/sofa-boot-gradle-plugin/pom.xml
#	sofa-boot-project/sofa-boot/pom.xml
#	sofa-boot-project/sofaboot-dependencies/pom.xml
Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2020

Codecov Report

Merging #673 into master will increase coverage by 0.41%.
The diff coverage is 76.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #673      +/-   ##
============================================
+ Coverage     51.40%   51.81%   +0.41%     
+ Complexity       87       77      -10     
============================================
  Files           276      291      +15     
  Lines          7988     8183     +195     
  Branches       1134     1139       +5     
============================================
+ Hits           4106     4240     +134     
- Misses         3434     3488      +54     
- Partials        448      455       +7     
Impacted Files Coverage Δ Complexity Δ
...onfigure/runtime/SofaRuntimeAutoConfiguration.java 100.00% <ø> (ø) 0.00 <0.00> (ø)
...webserver/StartupJettyServletWebServerFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...server/StartupUndertowServletWebServerFactory.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...m/alipay/sofa/boot/constant/SofaBootConstants.java 90.90% <ø> (ø) 0.00 <0.00> (ø)
...utoconfigure/startup/SofaStartupConfiguration.java 46.15% <46.15%> (ø) 0.00 <0.00> (?)
...boot/actuator/startup/SofaBootStartupEndPoint.java 50.00% <50.00%> (ø) 1.00 <1.00> (?)
...lipay/sofa/startup/spring/SpringContextAwarer.java 62.50% <62.50%> (ø) 0.00 <0.00> (?)
...va/com/alipay/sofa/startup/SofaStartupContext.java 72.72% <72.72%> (ø) 0.00 <0.00> (?)
...y/sofa/startup/spring/IsleSpringContextAwarer.java 75.00% <75.00%> (ø) 0.00 <0.00> (?)
...up/spring/StartupSpringApplicationRunListener.java 93.75% <93.75%> (ø) 0.00 <0.00> (?)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b841cb2...c9c836f. Read the comment docs.

Copy link
Contributor

@alaneuler alaneuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sofastack-bot sofastack-bot bot added cla:yes and removed cla:no labels Aug 8, 2020
@HzjNeverStop HzjNeverStop merged commit f69cf0f into sofastack:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide an endpoint to show the time cost details when application startups

4 participants