Skip to content

Conversation

@alaneuler
Copy link
Contributor

fix: #583

@alaneuler alaneuler requested review from caojie09 and glmapper March 9, 2020 03:33
Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Override
public boolean isLivenessHealth() {
for (HealthIndicator healthIndicator : healthIndicators) {
if (healthIndicator.getClass().getSimpleName()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use getName.

@caojie09 caojie09 merged commit ba44dba into sofastack:master Mar 9, 2020
@alaneuler alaneuler modified the milestone: 3.3.1 Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MultiApplicationHealthIndicator will trigger stackoverflow during health check

3 participants