Skip to content

Removing register system beanPostProcessor #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caojie09 merged 1 commit into from
Jan 6, 2020
Merged

Removing register system beanPostProcessor #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .../src/main/java/com/alipay/sofa/runtime/spring/RuntimeContextBeanFactoryPostProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,8 @@ public void postProcessBeanFactory(ConfigurableListableBeanFactory beanFactory)
.addBeanPostProcessor(new ReferenceAnnotationBeanPostProcessor(applicationContext,
sofaRuntimeContext, bindingAdapterFactory, bindingConverterFactory));

// work on all bean on the beginning, then reorder after all bean post processors being registered
RuntimeShutdownAwarePostProcessor runtimeShutdownAwarePostProcessor = new RuntimeShutdownAwarePostProcessor(
sofaRuntimeContext.getSofaRuntimeManager());
beanFactory.addBeanPostProcessor(runtimeShutdownAwarePostProcessor);
beanFactory.registerSingleton(RuntimeShutdownAwarePostProcessor.class.getCanonicalName(),
runtimeShutdownAwarePostProcessor);
beanFactory.registerSingleton(RuntimeShutdownAwarePostProcessor.class.getSimpleName(),
new RuntimeShutdownAwarePostProcessor(sofaRuntimeContext.getSofaRuntimeManager()));

if (beanFactory instanceof AbstractAutowireCapableBeanFactory) {
((AbstractAutowireCapableBeanFactory) beanFactory)
Expand Down
7 changes: 0 additions & 7 deletions ...time-sofa-boot/src/test/java/com/alipay/sofa/runtime/test/BeanPostProcessorOrderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,6 @@ public void testSofaRuntimeContextInject() {
Assert.assertNotNull(highOrderBeanPostProcessor.getSofaRuntimeContext());
}

@Test
public void testShutDownHook() throws Exception {
List<RuntimeShutdownAware> applicationShutdownAwares = getApplicationShutdownAwares();
Assert.assertNotNull(applicationShutdownAwares);
Assert.assertTrue(applicationShutdownAwares.contains(highOrderBeanPostProcessor));
}

@Test
@SuppressWarnings("unchecked")
public void testShutDownHookReordered() throws Exception {
Expand Down