Skip to content

Conversation

@alaneuler
Copy link
Contributor

@alaneuler alaneuler commented Dec 19, 2019

fix: #534

@codecov-io
Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #558 into master will increase coverage by 0.57%.
The diff coverage is 68.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #558      +/-   ##
============================================
+ Coverage     66.64%   67.22%   +0.57%     
  Complexity       91       91              
============================================
  Files           267      267              
  Lines          7657     7661       +4     
  Branches       1092     1094       +2     
============================================
+ Hits           5103     5150      +47     
+ Misses         1926     1873      -53     
- Partials        628      638      +10
Impacted Files Coverage Δ Complexity Δ
...ofa/runtime/service/binding/JvmBindingAdapter.java 55.81% <0%> (ø) 0 <0> (ø) ⬇️
...lipay/sofa/runtime/service/binding/JvmBinding.java 68.18% <100%> (+4.54%) 0 <0> (ø) ⬇️
.../runtime/service/component/ReferenceComponent.java 49.1% <100%> (+13.81%) 0 <0> (ø) ⬇️
.../sofa/healthcheck/impl/ComponentHealthChecker.java 71.42% <25%> (+18.79%) 0 <0> (ø) ⬇️
...fa/runtime/service/component/ServiceComponent.java 52.31% <50%> (+2.97%) 0 <0> (ø) ⬇️
.../sofa/runtime/spi/component/AbstractComponent.java 59.37% <90%> (+5.67%) 0 <0> (ø) ⬇️
...com/alipay/sofa/runtime/SofaRuntimeProperties.java 80% <0%> (+5%) 0% <0%> (ø) ⬇️
...ipay/sofa/rpc/boot/runtime/binding/RpcBinding.java 40.98% <0%> (+6.55%) 0% <0%> (ø) ⬇️
...m/alipay/sofa/runtime/spi/health/HealthResult.java 71.42% <0%> (+71.42%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803bbb4...7de405c. Read the comment docs.

@alaneuler
Copy link
Contributor Author

image

Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caojie09 caojie09 merged commit 5784ba9 into sofastack:master Jan 1, 2020
@caojie09 caojie09 added this to the 3.3.0 milestone Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sofaComponentHealthChecker display service/reference bingding

4 participants