Skip to content

Conversation

@alaneuler
Copy link
Contributor

@alaneuler alaneuler commented Dec 18, 2019

fix #544

@codecov-io
Copy link

codecov-io commented Dec 18, 2019

Codecov Report

Merging #556 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #556      +/-   ##
============================================
+ Coverage     66.61%   66.64%   +0.02%     
  Complexity       91       91              
============================================
  Files           267      267              
  Lines          7657     7657              
  Branches       1092     1092              
============================================
+ Hits           5101     5103       +2     
+ Misses         1927     1926       -1     
+ Partials        629      628       -1
Impacted Files Coverage Δ Complexity Δ
...pc/boot/runtime/converter/RpcBindingConverter.java 60.88% <0%> (+0.73%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be5488...a5e77af. Read the comment docs.

Copy link
Contributor

@caojie09 caojie09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caojie09 caojie09 merged commit 803bbb4 into sofastack:master Dec 19, 2019
@caojie09 caojie09 added this to the 3.3.0 milestone Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RPC service/reference timeout attribute in XML is restricted to int

3 participants