Skip to content

Fix banner text configuration. #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongZhang merged 4 commits into from
Jun 11, 2019
Merged

Fix banner text configuration. #433

QilongZhang merged 4 commits into from
Jun 11, 2019

Conversation

@QilongZhang
Copy link
Contributor

@QilongZhang QilongZhang commented Jun 10, 2019

@QilongZhang QilongZhang added the optimization Code optimization label Jun 10, 2019
@QilongZhang QilongZhang added this to the 3.1.5 milestone Jun 10, 2019
@ujjboy
Copy link
Member

ujjboy commented Jun 10, 2019

need to fix it in 2.x, too

@QilongZhang
Copy link
Contributor Author

QilongZhang commented Jun 11, 2019

need to fix it in 2.x, too

Ok

@codecov-io
Copy link

codecov-io commented Jun 11, 2019 •
edited
Loading

Codecov Report

Merging #433 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   68.55%   68.55%           
=======================================
  Files         132      132           
  Lines        3803     3803           
  Branches      515      515           
=======================================
  Hits         2607     2607           
  Misses        899      899           
  Partials      297      297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f15b4d...45393b1. Read the comment docs.

@QilongZhang QilongZhang merged commit 337e6aa into sofastack:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@straybirdzls straybirdzls straybirdzls approved these changes

Assignees

No one assigned

Labels

optimization Code optimization

Projects

None yet

Milestone

3.1.5

Development

Successfully merging this pull request may close these issues.

4 participants

@QilongZhang @ujjboy @codecov-io @straybirdzls