Skip to content

Conversation

@QilongZhang
Copy link
Contributor

cherry pick from #370

@QilongZhang QilongZhang added the enhancement New feature or request label Apr 3, 2019
@QilongZhang QilongZhang added this to the 2.6.2 milestone Apr 3, 2019
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #379 into 2.x will increase coverage by 1.72%.
The diff coverage is 71.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x     #379      +/-   ##
==========================================
+ Coverage   66.39%   68.12%   +1.72%     
==========================================
  Files         131      133       +2     
  Lines        3827     3890      +63     
  Branches      541      545       +4     
==========================================
+ Hits         2541     2650     +109     
+ Misses        990      939      -51     
- Partials      296      301       +5
Impacted Files Coverage Δ
...untime/service/helper/ReferenceRegisterHelper.java 72.72% <ø> (ø) ⬆️
...me/spring/factory/AbstractContractFactoryBean.java 87.17% <0%> (+35.32%) ⬆️
...ofa/runtime/spring/factory/ServiceFactoryBean.java 73.68% <100%> (+7.01%) ⬆️
...a/runtime/spring/factory/ReferenceFactoryBean.java 85.18% <100%> (+13.18%) ⬆️
...fa/runtime/service/client/ReferenceClientImpl.java 28.84% <100%> (+4.35%) ⬆️
...tegration/invoke/DynamicJvmServiceProxyFinder.java 61.68% <40%> (-4.28%) ⬇️
.../runtime/integration/service/SofaEventHandler.java 61.9% <50%> (ø) ⬆️
...a/runtime/service/binding/JvmBindingConverter.java 70% <70%> (ø)
...untime/spring/ServiceBeanFactoryPostProcessor.java 70.58% <73.33%> (+5.16%) ⬆️
...e/spring/ReferenceAnnotationBeanPostProcessor.java 83.07% <76.92%> (+16.41%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b73f2f...83e2964. Read the comment docs.

Copy link
Contributor

@glmapper glmapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@QilongZhang QilongZhang merged commit b1c7293 into sofastack:2.x Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants