Conversation
uh oH! that's IFD for now. will be fixed before this is merged into main.
guess i forgot to change this when i factored out the contents of that description lol
ehh this is kinda messy but it makes heavy use of properties and nothing else does. so this is good enough i suppose
this is purely necessary because of a quirk where it inserts a bunch of ugly braces
natively, xkb uses empty strings being equiv to null for all except options. that's why it was the way it was. but this is more sensible imo.
…orkspace layout config also tab-indicator is no longer nullable and i reordered a bunch of stuff.
`section` gives it a default value. but default value is meaningless for attrTag.
3 tasks
this file has been stale for Ages. and i don't actually want to keep this around right now.
Owner
Author
Owner
Author
|
check this out i made it usable Without being super tightly tied to home manager and such. my own system configuration no longer needs to consume niri-flake internals sodiboo/system@b75ca42 |
I tried it, and currently, the workspaces section seems to have some validation issues (I'm not entirely sure), it will validate |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello. i have decided that This is an arbitrary point in time at which i want to make relatively major internal structural changes to this flake.
so far, i've started with refactoring the settings module into a directory with a bit cleaner organization. notably, all of the rendering logic is now right next to the option definitions. i also made it internally use the "new" KDL representation from NixOS/nixpkgs#426828, which also means ditching the pure-nix serializer i had previously written.
because niri v25.11 has config includes, a lot of the config is now partial. so, there will be less "default values" hanging around of things you didn't configure. i also did some web development and made generated documentation for the settings that feels way nicer. check out what i've got so far
next up, i need to rework the modules for integrating those settings into a NixOS and/or home-manager configuration. in doing so, i'll finally deprecate the current
niri-flake.nixosModules.niriproperly, which has been a long time coming. i've already begun that work slightly by factoring out the binary cache to its own module. i also want to write a bit more welcoming documentation that's less out of date and less shaped like this mess. the current documentation is half-outdated and Slowly Rotting, most of it was written before NixOS even had a module to install niri. i will write new documentation that's better™, and accurately describes how i think niri-flake is best used today.i'll probably also be implementing the rest of the settings from v25.11. that is, i hope that this will close #1493. probably, i'll end up fixing a bunch of other issues and superseding some other PRs along the way. for instance, the new organization of the settings is already much more convenient to consume without flakes, and i'm hoping to make all niri-flake functionality work that way. that is, i'm trying to fix #1089.
and in general, until i'm done with this, i'm hesitant to merge any other PRs, because at best they'll cause annoying merge conflicts with this branch, and at worst they'll be made irrelevant by things i was going to do anyways or things that have changed enough to need to rewrite the functionality anyways.
yes, i know there are a bunch of open PRs. and to be honest, i haven't had the energy to look at most of them. i probably won't look at most of them either, until i'm done with these changes.