Skip to content

Return early when channels mismatch to skip expensive msgpack decoding #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rauchg merged 3 commits into from
May 9, 2016
Merged

Return early when channels mismatch to skip expensive msgpack decoding #107

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bcb29d
Return early when channels mismatch to skip expensive msgpack decoding
ryoqun May 7, 2016
f2e7a4c
Use substr!
ryoqun May 9, 2016
59c661e
Update index.js
ryoqun May 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,21 @@ function adapter(uri, opts){

this.uid = uid;
this.prefix = prefix;
this.channel = prefix + '#' + nsp.name + '#';
if (String.prototype.startsWith) {
this.channelMatches = function (messageChannel, subscribedChannel) {
return messageChannel.startsWith(subscribedChannel);
}
} else { // Fallback to slow indexOf impl for older Node.js
this.channelMatches = function (messageChannel, subscribedChannel) {
return messageChannel.indexOf(subscribedChannel) === 0;
}
Copy link
Contributor

@rauchg rauchg May 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just using substr ?

Copy link
Contributor Author

@ryoqun ryoqun May 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rauchg Fixed! f2e7a4c

Copy link
Contributor Author

@ryoqun ryoqun May 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rauchg I referred to https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith

I leant something from your suggestion, thank you!

}
this.pubClient = pub;
this.subClient = sub;

var self = this;
sub.subscribe(prefix + '#' + nsp.name + '#', function(err){
sub.subscribe(this.channel, function(err){
if (err) self.emit('error', err);
});
sub.on(subEvent, this.onmessage.bind(this));
Expand All @@ -91,6 +101,9 @@ function adapter(uri, opts){
*/

Redis.prototype.onmessage = function(channel, msg){
if (!this.channelMatches(channel.toString(), this.channel)) {
return debug('ignore different channel');
}
var args = msgpack.decode(msg);
var packet;

Expand Down