feat(sharded): add an option for dynamic private channels#526
Merged
darrachequesne merged 1 commit intosocketio:mainfrom Mar 13, 2024
Merged
feat(sharded): add an option for dynamic private channels#526darrachequesne merged 1 commit intosocketio:mainfrom
darrachequesne merged 1 commit intosocketio:mainfrom
Conversation
Member
|
Actually, I'm not sure that this is a good idea, as it could indicate that calling @MartinKolarik thoughts? |
Contributor
Author
|
@darrachequesne I think it makes sense if it's documented in regards to |
1391c28 to
033a358
Compare
033a358 to
9df1ee2
Compare
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As an alternative solution for #524, this:
dynamicPrivateChannels, which allows creating separate channels even for private rooms; defaults tofalseso there's no change in default behavior,false