Add withCredentials option #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
not sure what's up with CI, doesn't seem to be my changes |
Member
|
@DuBistKomisch thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the
engine.io.jsfile is the generated output ofmake engine.io.js, and should not be manually modified.The kind of change this PR does introduce
Current behaviour
withCredentialsis always set to true, despite the browser default being false, and can't be overridden.New behaviour
withCredentialscan now be overridden back to false if needed.Other information (e.g. related issues)
Fixes #495. Specifically cross-origin requests to servers setting
Access-Control-Allow-Origin: *break withxhr.withCredentials = true.Similar to the symptom of the recent problem in socketio/socket.io#3381 but a client-side workaround when the server-side can't be changed as it could in that case.