Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| mipi_dbi { | ||
| compatible = "zephyr,mipi-dbi-spi"; | ||
| spi-dev = <&spi2>; | ||
| duplex = <SPI_HALF_DUPLEX>; | ||
| mipi-mode = "MIPI_DBI_MODE_SPI_3WIRE"; | ||
| write-only; |
There was a problem hiding this comment.
[P1] Define MIPI-DBI bus mode on ili9342c node
The duplex and mipi-mode properties are placed on the mipi_dbi controller node, but the bindings for ILI9xxx panels expect these attributes on the display device (mipi-dbi-spi-device.yaml). Because the child ili9342c node lacks them, the driver falls back to the default 4‑wire/full‑duplex configuration while no dc-gpios is provided. When the display driver initializes it will execute the 4‑wire path and unconditionally toggle a command/data GPIO that does not exist, causing a runtime fault as soon as the display is enabled. Move duplex = <SPI_HALF_DUPLEX> and mipi-mode = "MIPI_DBI_MODE_SPI_3WIRE" into the ili9342c@0 node so the driver uses 3‑wire mode without a DC pin.
Useful? React with 👍 / 👎.
a57b085 to
5029813
Compare
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ce38cf024483229cebfbe9d4f42dda