fix: remove per line logging from sub-process calls#153
Open
JamesPatrickGill wants to merge 1 commit into
Open
fix: remove per line logging from sub-process calls#153JamesPatrickGill wants to merge 1 commit into
JamesPatrickGill wants to merge 1 commit into
Conversation
Logging each line from a sub-process in sbt can produce massive output for debugging and doesn't provide value to internal debugging or customers. This PR suggests we remove this.
|
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
37IulianPopovici
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging each line from a sub-process in sbt can produce massive output
for debugging and doesn't provide value to internal debugging or
customers. This PR suggests we remove this.
If the subprocess errors though, we should still get debug logs