Skip to content

improve accuracy by ensuring no truncation of dependencyTree output#127

Draft
twrichards wants to merge 1 commit into
snyk:masterfrom
twrichards:asciiGraphWidth-on-sbt-dependencyTree
Draft

improve accuracy by ensuring no truncation of dependencyTree output#127
twrichards wants to merge 1 commit into
snyk:masterfrom
twrichards:asciiGraphWidth-on-sbt-dependencyTree

Conversation

@twrichards
Copy link
Copy Markdown

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@ghost
Copy link
Copy Markdown

ghost commented Dec 13, 2022

This PR modifies files linked to issues tracked in Stepsize. You might want to review their status, priority, and scope.

Uninitialised variable
  • lib/index.ts
  • lib/index.ts
Missing error handling
  • lib/index.ts

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@twrichards twrichards changed the title add set asciiGraphWidth := 999999999 flag prior to the dependencyTree task to ensure no truncation ensure no truncation of dependencyTree output Dec 13, 2022
@twrichards twrichards changed the title ensure no truncation of dependencyTree output ensure no truncation of dependencyTree output - improving accuracy Dec 13, 2022
@twrichards twrichards changed the title ensure no truncation of dependencyTree output - improving accuracy improve accuracy by ensuring no truncation of dependencyTree output Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants