AWS ServiceAccountToken not accessible. #871
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanstanev
reviewed
Sep 16, 2021
Contributor
ivanstanev
left a comment
ivanstanev
left a comment
There was a problem hiding this comment.
Thank you for the contribution! I was wondering if you only meant to submit the fsGroup change?
Comment on lines
+179
to
+185
| {{- if .Values.volumes.projected.serviceAccountToken }} | ||
| - name: token-vol | ||
| projected: | ||
| sources: | ||
| - serviceAccountToken: | ||
| path: token | ||
| {{- end }} |
Contributor
There was a problem hiding this comment.
Hey @tektite-io I was wondering if this volume also needs to be mounted with a volumeMount? The example in the docs both declares the volume and a volumeMount - https://kubernetes.io/docs/concepts/storage/volumes/#example-configuration-secret-downwardapi-configmap
And if we have to mount this volume, where should it go?
Also, it looks like token expires by default after 1 hour according to the docs. How should we handle this?
3 tasks
|
🎉 This issue has been resolved in version 1.66.10 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
AWS ServiceAccountToken is not readable by the snyk-monitor process.
Using fsGroup and projected volume to solve the issue.
See similar problem: kubernetes-sigs/external-dns#1185