refactor: Make use of is_typing for Literal/Annotated detection.
#195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes soft use concept of `mapped_names` more generic and reuse it for walking `Annotated` value expressions.
Daverball
force-pushed
the
refactor/use-full-name-lookup-for-literal-and-annotated
branch
from
f1c791f to
3a36506
Compare
sondrelg
approved these changes
Dec 12, 2024
Member
sondrelg
left a comment
sondrelg
left a comment
There was a problem hiding this comment.
Looks good to me. Just have one clarifying question 👍
Daverball
deleted the
refactor/use-full-name-lookup-for-literal-and-annotated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes soft use concept of
mapped_namesmore generic and reuse it for walkingAnnotatedvalue expressions.Closes: #192