update for TipTap V3#657
Conversation
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Nice! I presume TipTap v3 has no breaking changes in the html or json data formats it exposes? Those would be the only breaking changes that matter as far as Dash users are concerned.
|
Well, there are breaking changes in Tiptap V3: https://tiptap.dev/docs/resources/whats-new Most of the changes are handled in the In their changelog, it's noted that some defaults have changed in the TextStyle API. I noticed that with If people made their own custom controls, there could be breaking changes. (No changes were needed for the examples in the docs) In the upstream Mantine, it's recommended (but not required) to upgrade to Tiptap 3, so it makes sense that this isn't considered a breaking change. However in DMC, it's not optional. Do you think this feature should wait for next major release? |
|
Unless you expect the next major soon, I think it's fine to include here. This will be generally helpful, and the potential breaking changes are quite deep in custom functionality, with the exception of those small styling changes which I agree seem more like bug fixes. Just make sure to call out in the changelog and docs where these changes might be needed and where to read about them. |
|
OK since there are no known breaking changes in our documented features, it should be OK to include this now. No plans for a major release any time soon. I'll update the migration guide and changelog. Thanks for your guidance on this! |
Closes #617
Updated for TipTap 3 as recommended in Mantine 8.3.0. Followed Migration Guide
Added new features available in TIpTap 3 text style extension: BackgroundColor, FontFamily, FontSize, LineHeight
Will add example to the docs for custom FontSize buttons: