-
-
Notifications
You must be signed in to change notification settings - Fork 77
NavLink Update for Active #504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d1bc1f9
adding support for navlink to set active based upon page navigation a…
BSd3v 8eea3c1
adding tests for navlink
BSd3v b063be7
DRY principle for test
BSd3v b98ad07
adjustment to allow for highlighting as active if the hyperlink is in…
BSd3v 9b068f8
Merge branch 'master' into navlink-update-active
AnnMarieW 6a36365
updated prop names and docstrings
AnnMarieW 8b42c78
updated tests
AnnMarieW 281cbdc
active bool | 'exact' |'partial
AnnMarieW 386dfb7
update test
AnnMarieW 1adda4e
update changelog
AnnMarieW 66b8f89
fix navlink without href
AnnMarieW 93285d9
updated partial
AnnMarieW 1a18874
updated partial
AnnMarieW bd9928b
updated test
AnnMarieW File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import dash | ||
| from dash import Dash, html, Output, Input, _dash_renderer, ALL, State | ||
| import dash_mantine_components as dmc | ||
|
|
||
| _dash_renderer._set_react_version("18.2.0") | ||
|
|
||
|
|
||
| def navlink_app(active): | ||
| app = Dash(__name__, use_pages=True, pages_folder='') | ||
|
|
||
| app.layout = dmc.MantineProvider([ | ||
| html.Div( | ||
| [ | ||
| dmc.NavLink(label=f"link-{x}", id=f"link-{x}", href=f"/link-{x}", active=active, | ||
| w=300) | ||
| for x in range(30) | ||
| ] | ||
| ), | ||
| dash.page_container | ||
| ]) | ||
| return app | ||
|
|
||
| def self_check_navlink(active, dash_duo, app): | ||
| dash_duo.start_server(app) | ||
|
|
||
| # Wait for the app to load | ||
| dash_duo.wait_for_element("#link-0") | ||
| els = dash_duo.find_elements('a[data-active]') | ||
| if isinstance(active, bool): | ||
| if active: | ||
| assert len(els) == 30 | ||
| assert len(dash_duo.find_elements('a:not([data-active])')) == 0 | ||
| else: | ||
| assert len(els) == 0 | ||
| assert len(dash_duo.find_elements('a:not([data-active])')) == 30 | ||
| return | ||
| else: | ||
| assert len(els) == 0 | ||
| for t in [1, 5, 10, 12, 13, 20, 22]: | ||
| dash_duo.find_element(f'#link-{t}').click() | ||
| els = dash_duo.find_elements('a[data-active]') | ||
| if active == 'exact': | ||
| assert len(els) == 1 | ||
| else: | ||
| if len(str(t)) > 1: | ||
| assert len(els) == 2 | ||
| else: | ||
| assert len(els) == 1 | ||
| for el in els: | ||
| assert el.get_attribute('id') in f"link-{t}" | ||
|
|
||
|
|
||
| def test_001nl_navlink(dash_duo): | ||
| app = navlink_app(True) | ||
| self_check_navlink(True, dash_duo, app) | ||
|
|
||
| def test_002nl_navlink(dash_duo): | ||
| app = navlink_app(False) | ||
| self_check_navlink(False, dash_duo, app) | ||
|
|
||
| def test_003nl_navlink(dash_duo): | ||
| app = navlink_app('exact') | ||
| self_check_navlink('exact', dash_duo, app) | ||
|
|
||
| def test_004nl_navlink(dash_duo): | ||
| app = navlink_app('partial') | ||
| self_check_navlink('partial', dash_duo, app) | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think
startsWithis going to lead to unintended consequences, andpartialshould instead useTo account for paths like:
If you use just
startsWith, thenhref='/al'would match all of these, but you really only want to match the first two.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you do this
and links looks like:
Then if you click on the first link neither is active and when you click on the second link then only the
/alpage is active.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BSd3v suggested this and it works well 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I see that's what you had too @alexcjohnson 😊 I was just fixated on the
href + '/'part and missed it.