Discard not ready connections from HTTP/2 pool #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP2 connections will unregister themselves from the pool once enter connected_read_only and disconnected states, and register themselves on init or after they reconnect. Fixes sneako#216
jswanner
commented
Oct 23, 2025
Comment on lines
+349
to
+355
| def connected(:enter, _old_state, data) do | ||
| {:ok, _} = | ||
| Registry.register(data.finch_name, {data.scheme, data.host, data.port}, __MODULE__) | ||
|
|
||
| {:keep_state, put_in(data.registered, true)} | ||
| end | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I couldn't only have the pool register itself when the connection enter :connected state, as HTTP2.PoolMetrics tests failed because instead of having multiple requests sent over a single HTTP/2 connection, individual HTTP/2 connections were created for each request.
Registering the pool in c:init/1 and then here after a reconnection fixed the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP2 connections will unregister themselves from the pool once enter connected_read_only and disconnected states, and register themselves on init or after they reconnect.
Fixes #216, replaces #227.