Fix WebSocket client handshake failing with non-ASCII header values#532
Merged
daniel-abramov merged 1 commit intosnapview:masterfrom Feb 7, 2026
Merged
Conversation
Fixing an issue where non-ASCII header values cause websocket handshake to fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WebSocket client handshake was incorrectly rejecting HTTP headers containing non-ASCII bytes. This occurred because
generate_request()calledHeaderValue::to_str()on custom headers, which fails for any non-ASCII content.HTTP headers are defined as octets per RFC 7230, not UTF-8 strings. This fix writes header values as raw bytes, preserving their original content.
Changes
to_str()+writeln!()with direct byte operations usingextend_from_slice()Fixes #531