Skip to content

Add support for rustls-platform-verifier#528

Open
FrankenApps wants to merge 1 commit intosnapview:masterfrom
FrankenApps:rustls-platform-verifier
Open

Add support for rustls-platform-verifier#528
FrankenApps wants to merge 1 commit intosnapview:masterfrom
FrankenApps:rustls-platform-verifier

Conversation

@FrankenApps
Copy link

Adds support for rustls-platform-verifier as mentioned in #522.

However contrary to the plan outlined in that issue I left the rustls-native-certs feature untouched for now.

I also did not implement support for additional root certificates (new_with_extra_roots), because it works differently than the current approach based on RootCertStore.

@FrankenApps FrankenApps force-pushed the rustls-platform-verifier branch from 22d57a0 to b94dfb0 Compare February 25, 2026 18:05
@FrankenApps
Copy link
Author

@daniel-abramov Is this something you would consider?

@FrankenApps
Copy link
Author

CI failure seems unrelated:

error: package `syn v2.0.117` cannot be built because it requires rustc 1.71 or newer, while the currently active rustc version is 1.68.2
Either upgrade to rustc 1.71 or newer, or use
cargo update -p [email protected] --precise ver
where `ver` is the latest version of `syn` supporting rustc 1.68.2
Error: Process completed with exit code 101.

Copy link
Member

@daniel-abramov daniel-abramov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@daniel-abramov Is this something you would consider?

Yes. I think it's the right direction in the long term.

The only concern I have with these particular changes is that cargo features are meant to be additive, and I think it could be seen as an unexpected behavior if one feature "silently overwrites" the other.

CI failure seems unrelated:

Oh right. I've just updated the master to incorporate the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants