Add support for rustls-platform-verifier#528
Open
FrankenApps wants to merge 1 commit intosnapview:masterfrom
Open
Add support for rustls-platform-verifier#528FrankenApps wants to merge 1 commit intosnapview:masterfrom
FrankenApps wants to merge 1 commit intosnapview:masterfrom
Conversation
22d57a0 to
b94dfb0
Compare
Author
|
@daniel-abramov Is this something you would consider? |
Author
|
CI failure seems unrelated: |
Member
There was a problem hiding this comment.
Thanks for the PR!
@daniel-abramov Is this something you would consider?
Yes. I think it's the right direction in the long term.
The only concern I have with these particular changes is that cargo features are meant to be additive, and I think it could be seen as an unexpected behavior if one feature "silently overwrites" the other.
CI failure seems unrelated:
Oh right. I've just updated the master to incorporate the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
rustls-platform-verifieras mentioned in #522.However contrary to the plan outlined in that issue I left the
rustls-native-certsfeature untouched for now.I also did not implement support for additional root certificates (
new_with_extra_roots), because it works differently than the current approach based onRootCertStore.