This repository was archived by the owner on Aug 22, 2025. It is now read-only.
[erc721-contract-call] feat: erc721-contract-call#1703
Open
abysnart wants to merge 1 commit intosnapshot-labs:masterfrom
Open
[erc721-contract-call] feat: erc721-contract-call#1703abysnart wants to merge 1 commit intosnapshot-labs:masterfrom
abysnart wants to merge 1 commit intosnapshot-labs:masterfrom
Conversation
ChaituVR
suggested changes
Mar 19, 2025
| { | ||
| "name": "xSGT NFT Voting Power Example", | ||
| "strategy": { | ||
| "name": "xsgt-nft-voting-power", |
Member
There was a problem hiding this comment.
should be same as strategy name
Member
There was a problem hiding this comment.
actually the name xsgt-nft-voting-power makes more sense than erc721-contract-call
| @@ -0,0 +1,105 @@ | |||
| import { formatUnits } from '@ethersproject/units'; | |||
Member
There was a problem hiding this comment.
Lint / tests are failing in this fail, could take a look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xSGT NFT Voting Power Strategy
Overview
This PR introduces a new voting strategy for NFTs where each token ID has a specific voting power. The strategy is useful for NFT-based governance where different token IDs carry different voting weights.
Use Case
The strategy enables Snapshot spaces to support voting with NFTs where:
Contract Requirements
The NFT contract must implement:
tokensOfOwner(address _owner) external view returns (uint256[])- Gets all token IDs owned by an addressgetVotingPower(uint256 _tokenId) external view returns (uint256)- Gets the voting power for a specific token IDImplementation Details
The strategy:
Testing
I've tested this strategy with the xSGT NFT contract (at address 0x...) and confirmed that it correctly calculates voting power based on token ID weightings.
Changes
Thank you for reviewing!