[hopr-stake-and-balance-qv] Improve hopr-stake-and-balance-qv strategy#1452
[hopr-stake-and-balance-qv] Improve hopr-stake-and-balance-qv strategy#1452QYuQianchen wants to merge 3 commits intosnapshot-labs:masterfrom
hopr-stake-and-balance-qv strategy#1452Conversation
hopr-stake-and-balance-qv strategyhopr-stake-and-balance-qv strategy
ChaituVR
left a comment
There was a problem hiding this comment.
I see an active proposal at https://snapshot.org/#/vote.hopr.eth/proposal/0xc7c172d20247df0c255a05f0773e321ef80c98af4f7a7bacec4e9a3a2435ab87 which is using this strategy. i would suggest to merge this after the end of this proposal
|
Thanks @ChaituVR for the review. Sounds good 👍. A related question: if the strategy implementation gets updated during an ongoing voting, will the scores being calculated according to the newer version or will the is the strategy anchored at a specific IPFS version/commit so it's calculated with an older version? |
Scores will be calculated with newer version but we have many cache systems, so if someone already tried to vote, they may see older voting power. so we always check if there is a active proposal in case someone want to update existing strategy, or other way is to create a new strategy and use it on new proposals ;) |
According to feedback from community members, here are some improvements and bug fixes to the voting strategy.
Changes proposed in this pull request: