Skip to content

Conversation

@kuhe
Copy link
Contributor

@kuhe kuhe commented Jul 24, 2024

When serializing the headers for an event stream event, the :event-type should take on the member name and not the member target id.

  const headers: __MessageHeaders = {
    ":event-type": { type: "string", value: "textEvent" }, // <-- here, for example
    ":message-type": { type: "string", value: "event" },
    ":content-type": { type: "string", value: "application/json" },
  };

This had not manifested until a recent AWS service in which the two values were not identical for apparently the first time.

@kuhe kuhe requested review from a team as code owners July 24, 2024 22:34
@kuhe kuhe requested a review from JordonPhillips July 24, 2024 22:34
@kuhe kuhe force-pushed the fix/eventstream branch from 9c9d2a3 to 4a996ac Compare July 24, 2024 22:44
@kuhe kuhe self-assigned this Jul 24, 2024
@kuhe kuhe force-pushed the fix/eventstream branch from 06bcc2d to 4a996ac Compare July 24, 2024 23:46
@kuhe kuhe merged commit a7843ad into smithy-lang:main Jul 24, 2024
@kuhe kuhe deleted the fix/eventstream branch July 24, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants