Skip to content

Revert "feat: omit endpoint params from generation in the client interface" #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
siddsriv wants to merge 1 commit into from
Closed

Revert "feat: omit endpoint params from generation in the client interface" #1348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...main/java/software/amazon/smithy/typescript/codegen/endpointsV2/EndpointsV2Generator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,10 +117,7 @@ private void generateEndpointParameters() {
RuleSetParameterFinder ruleSetParameterFinder = new RuleSetParameterFinder(service);

Map<String, String> clientInputParams = ruleSetParameterFinder.getClientContextParams();
//Omit Endpoint params that should not be a part of the ClientInputEndpointParameters interface
Map<String, String> builtInParams = ruleSetParameterFinder.getBuiltInParams();
builtInParams.keySet().removeIf(OmitEndpointParams::isOmitted);
clientInputParams.putAll(builtInParams);
clientInputParams.putAll(ruleSetParameterFinder.getBuiltInParams());

ObjectNode ruleSet = endpointRuleSetTrait.getRuleSet().expectObjectNode();
ruleSet.getObjectMember("parameters").ifPresent(parameters -> {
Expand Down
33 changes: 0 additions & 33 deletions ...c/main/java/software/amazon/smithy/typescript/codegen/endpointsV2/OmitEndpointParams.java
View file
Open in desktop

This file was deleted.