Skip to content

feat: automatic idempotency tokens for header values #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuhe merged 1 commit into from
Jul 3, 2024
Merged

feat: automatic idempotency tokens for header values #1327

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 27 additions & 4 deletions ...a/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,30 +1010,53 @@ private void writeNormalHeader(GenerationContext context, HttpBinding binding) {
binding.getMember(),
target
);
boolean isIdempotencyToken = binding.getMember().hasTrait(IdempotencyTokenTrait.class);
if (isIdempotencyToken) {
context.getWriter()
.addImport("v4", "generateIdempotencyToken", TypeScriptDependency.UUID);
}

boolean headerAssertion = headerValue.endsWith("!");
String headerBaseValue = (headerAssertion
? headerValue.substring(0, headerValue.length() - 1)
: headerValue);

if (!Objects.equals(memberLocation + "!", headerValue)) {
String defaultValue = "";
if (headerBuffer.containsKey(headerKey)) {
String s = headerBuffer.get(headerKey);
defaultValue = " || " + s.substring(s.indexOf(": ") + 2, s.length() - 1);
} else if (isIdempotencyToken) {
defaultValue = " ?? generateIdempotencyToken()";
}

String headerValueExpression = headerAssertion && !defaultValue.isEmpty()
? headerBaseValue + defaultValue
: headerValue + defaultValue;

// evaluated value has a function or method call attached
headerBuffer.put(headerKey, String.format(
"[%s]: [() => isSerializableHeaderValue(%s), () => %s],",
context.getStringStore().var(headerKey),
memberLocation + defaultValue,
headerValue + defaultValue
headerValueExpression
));
} else {
String value = headerValue;
String constructedHeaderValue = (headerAssertion
? headerBaseValue
: headerValue);
if (headerBuffer.containsKey(headerKey)) {
String s = headerBuffer.get(headerKey);
value = headerValue + " || " + s.substring(s.indexOf(": ") + 2, s.length() - 1);
constructedHeaderValue += " || " + s.substring(s.indexOf(": ") + 2, s.length() - 1);
} else if (isIdempotencyToken) {
constructedHeaderValue += " ?? generateIdempotencyToken()";
} else {
constructedHeaderValue = headerValue;
}
headerBuffer.put(headerKey, String.format(
"[%s]: %s,",
context.getStringStore().var(headerKey),
value
constructedHeaderValue
));
}
}
Expand Down