fix(shared-ini-file-loader): read config files from paths relative to homedir #1315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kuhe
approved these changes
Jun 21, 2024
Flackus
force-pushed
the
fix/reading-home-relative-config-files
branch
from
8f4b2f5 to
b6c2672
Compare
JordonPhillips
approved these changes
Jul 8, 2024
Flackus
force-pushed
the
fix/reading-home-relative-config-files
branch
from
b6c2672 to
a18ec40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-js-v3#5876
Description of changes:
If a config path relative to homedir is provided,
shared-ini-file-loadernow expands~to its absolute path and reads the config file successfully.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.