Retry requesting status up to 5 consecutive times when getting 5xx er… #270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors This should help gitlab in periods where gitlab has network issues. That happens once in a while, and during this time there are few 5xx errors (502 and 504). When one happens on a MR status request, then Marge just unassign the MR, or close and re-opens a new batch. When 5xx errors happen every 10 minutes, nothing gets merged.
Contributor
|
Thanks for fighting against the bad network. The retry facility would be even more useful if it could be extracted to a decorator. |
|
@qqshfox is that a requirement for this to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rors
This should help gitlab in periods where gitlab has network
issues. That happens once in a while, and during this time there are
few 5xx errors (502 and 504). When one happens on a MR status request,
then Marge just unassign the MR, or close and re-opens a new batch.
When 5xx errors happen every 10 minutes, nothing gets merged.