Attempt to fix #410 (failing scrutinizer checks)#412
Merged
Conversation
Collaborator
Author
|
👍🏿 Scrutinizer runs without errors: https://scrutinizer-ci.com/g/smalot/pdfparser/inspections/1b183de1-86bf-4232-b06b-b9f6f3a79c1b/log |
j0k3r
approved these changes
Apr 26, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I would like to block all open PRs until this problem is solved. Affects: #411 and #409
It seems that Scrutinizer fails if we use a newer PHPUnit version (tested 9.5), but it works with PHPUnit 7.5.x though. Have no time to investigate it any further right now, so I would keep PHPUnit 7.5 in Scrutinizer. Any objections?
Workaround: When running Scrutinizer adapt
dev-tools/composer.jsonon the fly to force PHPUnit^7.5(see Makefile).Fixes #410