Skip to content

Handle corrupted PDF#328

Merged
j0k3r merged 1 commit into
masterfrom
fix/corrupted-pdf
Aug 31, 2020
Merged

Handle corrupted PDF#328
j0k3r merged 1 commit into
masterfrom
fix/corrupted-pdf

Conversation

@j0k3r

@j0k3r j0k3r commented Aug 31, 2020 •
edited by k00ni
Loading

Copy link
Copy Markdown
Collaborator

Also:

  • remove some stuff from export (in .gitattributes)
  • move PHPStan parameters into the config file
  • move TestCase in tests folder (keeping the code base clean)
  • refined composer.json (use https for URL)

@j0k3r
Handle corrupted PDF
dfc539d 
Also:
- remove some stuff from export (in `.gitattributes`)
- move PHPStan parameters into the config file
- move `TestCase` in `tests` folder (keeping the code base clean)
@j0k3r j0k3r requested review from k00ni and smalot August 31, 2020 07:06
k00ni
k00ni approved these changes Aug 31, 2020
View reviewed changes

@k00ni k00ni left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense.

Although I would kept the Test namespace. The reason for it was to separate actual tests from test related code, like TestCase or test files like PDFs. But its fine for me 👍

@j0k3r j0k3r merged commit 2abf9c8 into master Aug 31, 2020
@j0k3r j0k3r deleted the fix/corrupted-pdf branch August 31, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k00ni k00ni k00ni approved these changes
@smalot smalot Awaiting requested review from smalot

Assignees

No one assigned

Labels

enhancement fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@j0k3r @k00ni