Skip to content

AMQP connector does not support disabling health check #2990

@soframel

Description

@soframel

The property "health-enabled" doesn't seem to be implemented at all in https://github.com/smallrye/smallrye-reactive-messaging/blob/main/smallrye-reactive-messaging-amqp/src/main/java/io/smallrye/reactive/messaging/amqp/AmqpConnector.java , even though the doc here states otherwise:
https://smallrye.io/smallrye-reactive-messaging/latest/amqp/health/

In addition, it would be useful to be able to enable only liveness or readiness probes individually (see 2552 , which was for RabbitMQ connector, but I think the same applies here).

See https://github.com/soframel/smallrye-reactive-messaging/blob/testHealthEnabledAMQP/smallrye-reactive-messaging-amqp/src/test/java/io/smallrye/reactive/messaging/amqp/HealthTest.java for a reproducer

I have tried implementing this in https://github.com/soframel/smallrye-reactive-messaging/tree/healthEnabledAMQP-clean , but am not 100% sure (because I use ConfigProviderResolver.instance().getConfig(); in AmqpConnector, I'm not sure this is correct?), but if you agree I could open a pull request.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions