feat(happy-app): show daemon label in session list subtitle#646
Open
HirokiKobayashi-R wants to merge 1 commit intoslopus:mainfrom
Open
feat(happy-app): show daemon label in session list subtitle#646HirokiKobayashi-R wants to merge 1 commit intoslopus:mainfrom
HirokiKobayashi-R wants to merge 1 commit intoslopus:mainfrom
Conversation
Display "daemon" label in the session subtitle when a session was started by the background daemon, so users can distinguish daemon- spawned sessions from terminal sessions at a glance. Closes slopus#645
HirokiKobayashi-R
force-pushed
the
feat/session-started-by-label
branch
from
e14c8b3 to
4d3508c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadata.startedBy === 'daemon', making it easy to distinguish daemon-spawned sessions from terminal sessionsstartedByfield toMetadataSchemaso the field is preserved through Zod parsingsession.startedByDaemontranslation key to all 10 languagesCloses #645
Changes
storageTypes.tsstartedBy: z.string().optional()to MetadataSchemasessionUtils.ts· daemon(localized) to subtitle when startedBy is daemon_default.ts+ 10 translation filessession.startedByDaemonkeyDisplay
Test plan
path · daemonyarn typecheck— no new errors)