-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Add two-cols-footer layout #2342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Add two-cols-footer layout #2342
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hey @antfu , |
|
Thanks @parthz-13! Looks great, but one change seems unrelated and should be removed, see comments. |
Hey @JPustkuchen, thanks for catching that. It was an unintentional whitespace change. I’ve reverted it now. |
|
hey @kermanx, just wanted to check if you had time to review this PR. Please let me know if there’s anything I should adjust or clarify. |
@slidev/client
create-slidev
create-slidev-theme
@slidev/parser
@slidev/cli
@slidev/types
commit: |
|
Why not use the ---
layout: two-cols-header
---
This shows at the top, aligned to the start (top) of the grid
::left::
# Left
This shows on the left
::right::
# Right
This shows on the right
::bottom::
This spans both columns at the bottom (footer)
<style>
.two-cols-header {
column-gap: 20px; /* Adjust the gap size as needed */
}
</style> |
Closes #2332
Summary
Adds a new two-cols-footer layout that complements the existing two-cols-header layout. This layout displays two columns with an optional top section and a footer section that spans both columns at the bottom.
Test Slide Screenshot
Implementation Details
• Follows the same pattern and conventions as two-cols-header.vue
• Uses CSS Grid with 3 rows: auto 1fr auto
• Maintains consistent prop structure (class, layoutClass)