feat(web-api): add slackLists methods #1537
Conversation
srtaalej
added
enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1537 +/- ##
============================================
+ Coverage 72.89% 73.08% +0.19%
- Complexity 4413 4476 +63
============================================
Files 477 477
Lines 14081 14214 +133
Branches 1473 1483 +10
============================================
+ Hits 10264 10388 +124
- Misses 2944 2946 +2
- Partials 873 880 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o ale-feat-lists-mthds
…va-slack-sdk into ale-feat-lists-mthds
slack-api-client/src/test/java/test_locally/api/MethodsTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
🪬 question: Was this autogenerated with the responses of the remote tests? I'm not certain that this matches responses I find...
There was a problem hiding this comment.
👾 question: Should these filenames perhaps match:
...request/slack_lists/SlackListsAccessDeleteRequest.java
✨ ramble: I am referencing adjacent implementations for this:
There was a problem hiding this comment.
i think this can be a followup but i like that it matches the docs 🫰
...nt/src/main/java/com/slack/api/methods/request/slacklists/SlackListsAccessDeleteRequest.java
Show resolved
Hide resolved
| String botToken = System.getenv(Constants.SLACK_SDK_TEST_BOT_TOKEN); | ||
|
|
||
| /* | ||
| * remove the @Ignore from the tests after setting up botToken | ||
| */ | ||
| @Test | ||
| @Ignore |
There was a problem hiding this comment.
🤖 note: Our test runner is still WIP but perhaps these can be uncommented before for testing purposes?
…lacklists/SlackListsAccessDeleteRequest.java Co-authored-by: Eden Zimbelman <[email protected]>
This PR adds support for the following slackLists API methods and addresses issue #1503 :
Create, AccessDelete, AccessSet, DownloadGet, DownloadStart, ItemsCreate, ItemsDelete, ItemsDeleteMultiple, ItemsInfo, ItemsList, ItemsUpdate, UpdateCategory (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.