[MNT] Remove <3.13 bounds from soft dependencies in all_extras #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the `python_version < '3.13'` markers from optional soft dependencies in the `all_extras` group in `pyproject.toml`, as discussed in issue sktime#478. No dependency versions were changed other than dropping the Python version constraints. Compatibility with Python 3.13 and NumPy 2 will be validated in CI.
Abdulwahid7027
requested review from
SaiRevanth25,
felipeangelimvieira and
fkiraly
as code owners
Collaborator
|
you may have to change some of the bounds to <3.14 |
Author
|
Updated the dependency bounds as suggested ( |
Updated optional dependencies to conditionally include lifelines and ngboost for Python versions less than 3.14.
Author
|
Updated the optional dependencies to restrict only lifelines and ngboost on Python < 3.14, as requested. Other <3.13 markers remain removed. Ready for CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
python_version < '3.13'constraints from the optional dependencies in theall_extrasgroup ofpyproject.toml, as per issue #478. No other version constraints were modified. Compatibility with Python 3.13 and NumPy 2 will be checked via CI.Fixes #478.